-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1104 add useraffiliation to the base user model #1126
Conversation
@@ -38,6 +38,8 @@ def test_user_list(self): | |||
|
|||
def test_user_create(self): | |||
user_data = { | |||
'profile-TOTAL_FORMS': '1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We changed the user creation form to a formset, so we need to include the profile ManagementForm data here or it will get angry.
I'm pretty pleased with the state of this PR. |
This is the basis for code to add profile information to a User for tom_base.
Current issues:
Solutions to nonexistant profiles:
RelatedObjectDoesNotExist: User has no profile.
error and create profile.save_profile
. This has the benefit of causing every new user to automatically have a profile, and updating all old ones automatically as they log in. Downside is using signals which adds new code.user_extras
. Has the benefit of no "new" code, but feels like the wrong place for this type of functionality.